Vanilla html / css integration using GRID

Community feedback

• 

  Rohit Kumar•560

  @rohitKumar38344Posted almost 3 years ago

  congratulations @EdouardHrgt for completing your challenge. I have learnt a lot from your code. My suggestion for you: 1,You can use margin: 100px auto on container to center it instead of using absolute positioning. 2, You can also remove the explicit height from container it's make content little bit stretchy. 3, You can remove gap property it's written unnecessarily in your code. 4, You can remove the width and height 100% on col-1 it's not necessary there. 5, on h1 you can remove the width as well it will fix your layout and from paragraph as well inside col-1

  Hope it helps :D

  Marked as helpful

  0

  ---

  

  edouard herrengt•970

  @EdouardHrgtPosted almost 3 years ago

  @rohitKumar38344 Tanhx for your return. I agree with you mainly on my use of height. I have the dendency to over-use it instead of use margins / paddings of child elements to form the final height... I'll try to do this way next time !

  0