Design comparison
Community feedback
- @correlucasPosted about 2 years ago
πΎHello SpartanUI, congratulations for your new solution!
I saw your preview site and everything is nice, I liked the custom bar you've added to the bottom.
Here's my tips for you:
1.To make the image and the container responsive replace the
width
withmax-width
.2.To make the image respecting the container size use
max-width: 100%
anddisplay: block
3.Is better you add
min-height: 100vh
to the body and not to the container, to have more control to give the card alignment:display: flex; min-height: 100vh; justify-content: center; align-items: center;
4.You don't really need a div to add the background color, just drop it into the
body
.body { background-color: var(--gray); }
π I hope this helps you and happy coding!
Marked as helpful1@Unal-InanliPosted about 2 years ago@correlucas Cheers for the tips lucas, your points about the image is a delight.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord