Design comparison
Community feedback
- @mattstuddertPosted almost 5 years ago
Your solution looks awesome, Jun! Just a quick heads up that the
vh
units are currently throwing off the screenshot. I'd recommend only using thevh
unit in very specific circumstances, as it can have unintended consequences, especially on short viewports. Instead, I'd let the height on the inner content dictate the height of the parent. It's much better to usemargin
andpadding
on elements than forcing theheight
directly.Keep up the great work!
1@JunYuHuangPosted almost 5 years ago@mattstuddert Thanks Matt for the tip! Didn't realize using vh units was not recommended for most cases. Margin and padding aside, what do you think about using percentages instead?
0@mattstuddertPosted almost 5 years ago@JunYuHuang I'd recommend avoiding setting the
height
of an element wherever possible, regardless of the unit. This is especially true for elements that contain a lot of content. It's fine in very specific instances, but should be mostly avoided.0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord