@mkboris
Posted
Hi AdamullaOsas nice work, the sizing can be different because of design assumptions and actual browser rendering, also things like viewport size, css resets also play a part. Given that, it's usually not a major issue if the design deviates slightly from the original as long as the project's functionality remains intact.
Some things you should look at
- The social links are supposed to be anchor
a
tags styled liked buttons notp
- Avoid setting fixed heights and widths on elements as this will cause lots of issues with the responsiveness of your layout, the element's content and using padding should determine it's size. Use
max-width
ormin-height
if you absolutely have to and the units should be relative units likerem
. - Font-size should be written in
rem
not px.
Hope this helps