vanilla css QR code component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Eli, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for Accessibility
  • remove all margin from .card class
  • you can remove height from img because it is superfluous
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Zorah•20

  @ZorahScopePosted over 2 years ago

  @denielden

  Thanks for being so in-depth with the feedback. I'll go through and apply all the suggestions when I get the chance.

  Much Appreciated 😊

  1

  

  Zorah•20

  @ZorahScopePosted over 2 years ago

  @denielden

  Thanks again for your feedback. After applying those fixes I pushed it further doing the following

  • Cleaned up my html by removing unneeded elements and internal css
  • Applied best practices with accessibility by using both HTML5 and ARIA markup
  • Pushed the attribution to the bottom

  I learned a lot from this

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @elixy You are welcome! Well done, Now it's much better :) Keep it up

  0