Design comparison
Solution retrospective
pls tell me where am wrong and explain well
Community feedback
- @elaineleungPosted about 2 years ago
Hi Allen, good job here! I just got three things to point out:
-
In your report, there are many accessibility issues that you need to firstly take care of; these are mostly about the tags that are in the
<body>
tag right that really should belong in the<head>
tag. Try to move them to the head tag and see if that helps to get rid of some issues. -
Try reorganizing the folders in your repo since the images are not showing at all. Right now, your
img
folder is in thecss
folder; theimg
folder normally should not be under thecss
folder. -
The container in the desktop view is very big right now. Instead of
width: 90%
, trywidth: min(90%, 28rem)
.
Hope some of this can help you out.
Marked as helpful2 -
- @abdelrhmanKhPosted about 2 years ago
Hi ALLEN the Problem with the photos that you included
<img src="/resource/css/img/icon-star.svg" alt="star" class="circle-star"> //you should remove the / <img src="resource/css/img/icon-star.svg" alt="star" class="circle-star"> // or Put The dot <img src="./resource/css/img/icon-star.svg" alt="star" class="circle-star">
second As you have only one box in the middle I prefer using the grid for this but you can add a min-width of 300px and max width of 450px so that it keeps it simple and as the design
.container { display: block; min-width: 300px; max-width: 450px; }
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord