vanilla css and html

Community feedback

• 

  Samdevtechnology•130

  @SamdevtechnologyPosted over 1 year ago

  Hello there 👋. Congratulations on job well done! 🎉 🎉 🎉

  • I would like to make some suggestions concerning your code that might be of help.

  HTML 🏷️:

  • This solution generates accessibility error report: "All page content should be contained by landmarks". This is due to a non-semantic markup, which causes a lack of landmark for a webpage.

  • So fix this by replacing the <section class="container"> element with the semantic element <main> along with <div class="avatar"> into a <footer> element in your index.html file. You can also change the <div class="col-1"> and <div class="col-2"> to a <section> as they are both sections in the main component.

  • What is meant by landmark ?: They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers. We make use of sematic elements to provide landmarks to our webpage example includes <main>, <aside>, <footer>, etc., instead of relying on generic elements like <div> or <span>.

  • Every webpage should contain one <main> element and it should include all content directly related to the page's main idea, there should only be one per webpage.

  HEADINGS ⚠️:

  • This solution generated accessibility error report: Page should contain a level-one heading. This is due to the lack of a level-one heading <h1>.

  • Headings provide structure to a webpage. It helps Search engines and Users to determine the most important piece of texts in a webpage.

  • Every webpage must have at least one h1 element identifying and describing the main content(text) of the page.

  • recommend you change your <h3> to an <h1> as it the main heading in the webpage

  Well done for completing this challenge 👍

  I hope have been of help, Please feel free to ask any question

  Happy Coding 🎉

  0