Design comparison
SolutionDesign
Community feedback
- @romila2003Posted about 2 years ago
Hi @guusteak,
Congratulations 🎉 for completing this challenge, the API component looks great and is functional and responsive. There are some issues regarding your HTML, and CSS I want to address:
- You are missing the
title
tag within thehead
tag e.g.<title>Advice Generator App</title>
- It is best practice to wrap the main content within the
main
tag which would ensure that your content is wrapped within the correct landmarks e.g.<main class="container"></main>
- Even though your API is functional on normal browsers, it won't work on Firefox without the clear cache e.g.
fetch(URL, {cache: 'no-cache'}),
Overall, great attempt and wish you the best for your future projects 👍.
Marked as helpful1 - You are missing the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord