Vanza Setia• 27,795
@vanzasetia
Posted
Hello, Carlos Urtubia! 👋
Well done on this challenge! Your solution looks great! 👍
I have some feedback on this solution.
- I am not sure about the
type="Email"
. It has an uppercase E which I would expect it should be lowercase. Unless everything is fine then I would recommend making the value for thetype
attribute to be lowercase letters. input
withtype="submit"
was used before thebutton
element exist. It's best to avoid using legacy elements. So, I recommend using thebutton
element instead.- There should not be text in
span
anddiv
alone whenever possible. Instead, wrap the text with a meaningful element like a paragraph element.
I learned recently that innerHTML
has a security risk. But, I think injecting an error message would not cause any security issues. So, I have one question, what do you think about innerHTML
as far as the security concern?
That's it! I hope this helps. 😊
Marked as helpful
0
Carlos Urtubia• 160
@CarDeku
Posted
@vanzasetia Thank you very much for your feedback
0
Vanza Setia• 27,795
@vanzasetia
Posted
@CarDeku You are welcome! 👍
0