Validate form

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello, Carlos Urtubia! 👋

  Well done on this challenge! Your solution looks great! 👍

  I have some feedback on this solution.

  • I am not sure about the type="Email". It has an uppercase E which I would expect it should be lowercase. Unless everything is fine then I would recommend making the value for the type attribute to be lowercase letters.
  • input with type="submit" was used before the button element exist. It's best to avoid using legacy elements. So, I recommend using the button element instead.
  • There should not be text in span and div alone whenever possible. Instead, wrap the text with a meaningful element like a paragraph element.

  I learned recently that innerHTML has a security risk. But, I think injecting an error message would not cause any security issues. So, I have one question, what do you think about innerHTML as far as the security concern?

  That's it! I hope this helps. 😊

  Marked as helpful

  0

  ---

  

  Carlos Urtubia•160

  @CarDekuPosted over 2 years ago

  @vanzasetia Thank you very much for your feedback

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @CarDeku You are welcome! 👍

  0