Design comparison
SolutionDesign
Community feedback
- @dtp27Posted over 2 years ago
Hi Alexis!
Pretty good solution overall! A few things I would recommend:
- I see you're using Flexbox in the card. I would also use it in the
body
, since that will then center your entire card on the page. Also includemin-height: 100vh;
in the body to ensure the content takes up the whole page (i.e. it'll be centered relative to the entire page). 2 . I would also change thewidth
property in yourimg
tomax-width: 100%;
. This will ensure the image scales down responsively with smaller screen sizes. - I recommend setting the base font-size in the
body
, then usingrem
to scale fonts from the different elements up and down. This can make it easier to control all of the fonts. - I don't think you need those
<br>
elements in your paragraph to match it "line-for-line". Pay attention to the design font sizing and weights, and it should take care of itself.
Let me know if you have any questions or thoughts.
Happy coding!
Dan
Marked as helpful1@iTwiixZPosted over 2 years ago@dtp27 Thank you for the review! It's been a while since I used html and pure css !
I would apply this for the next :D
1 - I see you're using Flexbox in the card. I would also use it in the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord