using vars in CSS

Community feedback

• 

  P

  Mohammed-Hassan•120

  @Mohammed-BataPosted 26 days ago

  Looks good. 1.It is links, so should be

  <li><a href="#" >Github</a></li>. 2.to add cursor while hover ul li a:hover{ Pointer:cursor; } I hope you find that helpful.

  0
• 

  Toskytd•100

  @ToskytdPosted 26 days ago

  very detailed work...i think you failed to add your cursor type and color...otherwise it's brilliant work.

  0
• 

  Gautam Sarkar•240

  @gautam-32b7Posted 26 days ago

  Hi there!

  Your solution looks amazing. However, there are a few mistakes.

  <ul class="profile__social-links">
      <li class="profile__social-link">GitHub</li>
  </ul>
  

  Use anchor tag. The <a> tag defines a hyperlink, which links from one page to another.

  <ul class="profile__social-links">
      <li class="profile__social-link"><a href="#">GitHub</a></li>
  </ul>
  

  Use rem over px. rem units are based on the document's root element (HTML) and are therefore more flexible and responsive than px units.

  html {
      font-size: 62.5%;
  }
  

  I hope you find this helpful, and happy coding!

  0