Using simple html css

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 3 years ago

  To fix accessibility issues you need to wrap everything in main tag instead of using div, as div doesn't have any semantic meaning. Also, Frontend Mentor requires at least one h1 tag which isn't always possible in some components.

  Also, in your img tag of clock icon, you have an empty srcset and alt

  Marked as helpful

  1
• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @yadneshdevkar ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

  Here are some of the tips I like to provide.

  • I suggest you to try transition on hoverable elements like image, heading and creator name.
  • Please try BEM for naming element classes. It will help you a lot on bigger projects.

  https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  1

  ---

  

  Yadnesh Devkar•30

  @yadneshdevkarPosted almost 3 years ago

  @tymren608 thank you so much for getting over my solution and recommending me I will definitely work over it .

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Yadnesh, good work!

  Try using Flexbox, it can help you better center elements on the page: give the flexbox and height properties to the body and remove all margin from the .parent class.

  Read the guide -> Flexbox

  Note: Flexbox aligns to the size of the parent container.

  You can use the vh measurement for the height... Viewport Height handles the sizing of an element in relation to the height of the browser window.

  In the end, to make it look as close to the design as possible, lower the value of border-radius in the .equi-img class to 1 rem.

  I hope that helps ;)

  Marked as helpful

  0

  ---

  

  Yadnesh Devkar•30

  @yadneshdevkarPosted almost 3 years ago

  @denielden thank you so much for the tips ,I will sure use flexbox properties i'm going to use it in smart card challenge please have a look on it, I just need someone to guide me so i can improve once again thank you.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @yadneshdevkar You are welcome! Don't forget to mark the comment as helpful!

  Thank you and Happy coding :)

  Marked as helpful

  0
• 

  Yadnesh Devkar•30

  @yadneshdevkarPosted almost 3 years ago

  ok... thank you sure I Will work over it .

  0