Design comparison
SolutionDesign
Solution retrospective
Hi. This is my first project using Sass module system to split up my scss code for each component.
The result is quite good enough but I'm not really sure if it works well on every browser because I use picture
element to change image based on the screen size
Any feedback are very appreciated. Thank you 😀
Community feedback
- @ChamuMutezvaPosted over 3 years ago
- let your
alt
values be unique and descriptive to allow users who rely on assistive technology to visualise the message that is being put across. There is 2 images with the following messagealt="img transform"
and other values such ashamburger
are not that descriptive in my opinion. For decorative images use an empty alt value - using more than one
h1
element does not cause errors , but is not among best practices as it can cause confusion to assistive tech users. - pretty cool with the fixed navigation and a responsive site. Happy coding
0@boedegoatPosted over 3 years ago@ChamuMutezva thank you for your feedback. Really appreciated that
0 - let your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord