@correlucas
Posted
๐พHello @obhasa12, Congratulations on completing this challenge!
๐จ Here are some tips to improve your component design:
1.You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the <div>
that wraps each card with <article>
you can wrap the paragraph with the quote with the tag <blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div>
is only a block element without meaning.
2.To add the two wave
svg background images in the (top/bottom),, the best way is by using background-image
to manage it since adding them to the body
you make sure it will be under everything, to manage different images inside a single css property as background-image
you use the comma inside each properties declare the single modification for each wave svg image separated. See the code below to see your solution with those backgrounds applied:
@media (min-width: 64em)
body {
background-image: url(../images/bg-pattern-top-desktop.svg), url(../images/bg-pattern-bottom-desktop.svg);
background-position: left -185px top -236px, right 10px bottom -300px;
background-repeat: no-repeat;
background-attachment: fixed;
background-size: contain, contain;
display: flex;
flex-flow: row wrap;
margin: 67px 118px;
}
โ๏ธ I hope this helps you and happy coding!
Marked as helpful
@obhasa12
Posted
@correlucas hallo Lucas, thank u for the feedback. I will implement your suggestions for the next project, it's really helpful