@VCarames
Posted
Hey @obhasa12, some suggestions to improve you code:
- Add the following to your Body Element to center you background image and content:
body {
min-height: 100vh;
display: flex;
justify-content: center ;
align-items: center ;
flex-direction: column ;
background-position: center;
background-size: cover;
}
-
Once applied you'll have to play around with the log and social media icons to place them where you want them to be.
-
The "button" was created with the incorrect elements. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
-
To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
More Info:
https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9
- Your CSS Reset is extremely bare, you want to more to it. Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
- While having interactive content (cards, links, icons, buttons, etc…) can definitely make content less static, if not done properly, it can actually have negative effect on your users experience. By simply just applying a “hover” effect to your content, you’re assuming that every device is compatible with “hover” effects. Unfortunately, most devices are not. To provide your users a better experience, you can use the @media (hover: hover) . Now users that that are devices that are not “hover” compatible will be able to enjoy your content.
More info:
https://css-tricks.com/solving-sticky-hover-states-with-media-hover-hover/
Happy Coding!
Marked as helpful