Skip to content
Submitted about 2 years ago

solution

naeun choi•10
@naeun0875
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Huddle landing page with a single introductory section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Kristina Radosavljevic•380
    @KristinaRadosavljevicPosted about 2 years ago

    Hi there, and congrats on completing the challenge :)

    I looked through your code and I have a couple of suggestions that you might want to consider:

    • You could try to get this solution a bit more responsive. A few ideas to start with - don't set a fixed width for the <body>. This will make your layout overflow to the sides (which is never a good idea) even if your user's screen is only a couple pixels less than 1440px. Another best practice you should adopt very early on is to get comfortable using responsive units like rem instead of fixed ones like px. And finally, I think you can set the media query breakpoint earlier than 375px - it's always best to look at your layout and see where it starts to break.
    • In your HTML, I'm not sure I would use <h2> for that description. Headings should be used as titles for a section, etc. This looks like a plain old <p> to me :) Also, the Register button is probably supposed to take you to another page where you can register, so in this case I believe the <a> element is more appropriate (even though it may look like a button).
    • For the sake of better user experience, I'd suggest adding the cursor: pointer; property to all the clickable elements.

    Hope this helps and once again good job :)

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord