Design comparison
Solution retrospective
I use background-image to load the origin design picture to see wether the layout match. The result seems good. But I just wonder is there any other methods.
Community feedback
- @Sdann26Posted over 2 years ago
Hi !
Congratulations for finishing this challenge, the layout has turned out quite well!
Now you just need to fix the accessibility problems you have, as you can see frontend mentor when you finish a challenge it shows you a report of HTML and accessibility errors and our duty is to try to fix them all.
In your case you have two problems, you have not used the <main> tag and you are missing a <h1> in your project. It is important to add <main> as it contains the main content of your page inside the body. While the <h1> tag should always be present once per page.
We solved this quickly by making the following changes:
- Change
<div id="card">
to<main id="card">
. - Change
<h2>Improve your front-end skills by building projects</h2>
to<h1>Improve your front-end skills by building projects</h1>
.
With this you should no longer have any errors, so generate a new report.
I hope you find my comments helpful.
Good Coding!
Marked as helpful1@akaigyouhouPosted over 2 years ago@Sdann26 Thank you for your reminding. You suggestion is very helpful for me! I will make the changes in my following projects. Sincerely appreciate your kind suggestion!
1 - Change
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord