Using React | Scss | Scss Module | Axios | Responsive

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

• So fix it by replacing the <div id="root"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

• They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

BUTTONS 🖲️:

• This solution had generated accessibility error reports due to lack discernible text for <button> element

• The <button> must have discernible text that clearly describes the destination, purpose, function, or action for screen reader users.

• Screen reader users are not able to discern the purpose of elements with role="link", role="button", or role="menuitem" that do not have an accessible name.

• The <button> name rule has five markup patterns that pass test criteria:

<button id="al" aria-label="Name"></button>

<button id="alb" aria-labelledby="labeldiv"></button>

<div id="labeldiv">Button label</div>

<button id="combo" aria-label="Aria Name">Name</button>

<button id="buttonTitle" title="Title"></button>

• Ensure that each <button> element and elements with role="button" have one of the following characteristics:

  • Inner text that is discernible to screen reader users.
  • Non-empty aria-label attribute.
  • aria-labelledby pointing to element with text which is discernible to screen reader users.
  • role="presentation" or role="none" (ARIA 1.1) and is not in tab order (tabindex="-1")

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!