Skip to content
Submitted over 2 years ago

using React and Sass

f5rcbh•190
@f5rcbh
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

this is my first time to use React with Sass it was soo FUN i have learn so mush with it even with Github (push , pull , merge etc..) . Hope you all like it , and please if there any suggestion tell me , thank you <3

Community feedback

  • jerry•300
    @realsalePosted over 2 years ago

    Yo! @f5rcbh,

    Nice job, you've got some alignment skills, you properly centered your content.

    Just need a little modification and it will look like the same

    I guess the obvious things you need enhancement are:

    • reduce padding in the content
    • inconsistent font-sizes
    • line-height/leading
    • little tweaks in margin

    The next thing is to addressed accessibility issues, make sure you're implementing semantic elements when structuring a webpage.

    Marked as helpful
    1
    f5rcbh•190
    @f5rcbhPosted over 2 years ago

    @realsale thx for that , and i will make it more good thx for the advice <3

    0
    jerry•300
    @realsalePosted over 2 years ago

    @f5rcbh welcome and keep up the good work bro.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord