Skip to content
Submitted about 1 year ago

Using position

océane•230
@Ocece77
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi this is my first project on FrontendMentor !!

What did you find difficult while building the project?

Deploy it tbh haha 😭

Which areas of your code are you unsure of?

// .card{ margin: 165px auto; //

I think there's a simple way to center it (maybe with display : flex 🧐 and justify-content and align-item : center )

Do you have any questions about best practices?

I think that I can optimise this code but idk how so any suggestion would be nice !

Community feedback

  • Anthony Licata•170
    @anthonyplicataPosted about 1 year ago

    This looks great honestly!

    I had gotten good advice for centering the content on this one as well.

    I do use flex now, but for flex or grid I was told to set min-height to 100vh. Seemed to resolved a whole lot for me.

    Marked as helpful
    1
    océane•230
    @Ocece77Posted about 1 year ago

    @anthonyplicata oki I take note! I'll try to apply the min-width at 100vh next time on a project, plus there are lots of mini project on Frontend Mentor where you have to center the main content !

    Thank you for your advice! 👍🏿

    0
    Anthony Licata•170
    @anthonyplicataPosted about 1 year ago

    @Ocece77 For sure! Especially the newbie ones. Took me a few projects for this advice to finally set in lol.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord