Design comparison
Solution retrospective
Feedback is more than welcome! This is my first attempt at coding HTML and CSS and it was great fun. I have learned a ton and would love to hear how I can further improve it.
Community feedback
- @tesla-ambassadorPosted over 2 years ago
Hey Tan Yi Hao, pretty neat solution! I am glad you had fun with this! In order to resolve your accessibility issues, you might want to consider the following:
- You might want to add a <main></main> landmark to contain your <div> tags this enables the browser to easily navigate the website. There are different types of landmarks your could use like <header> for the header section <main> for your main content < footer> for your footer All this is used to ease accessibility of your website by people who might be using screen readers and other features of the like.
- You might also consider adding an <h1> tag it's recommended to ease accessibility! In your case, you might add the <h1> on the "Improve your front-end skills by building projects" text. Happy coding!
Marked as helpful2@shashreesamuelPosted over 2 years agoJust to add to the feedback regarding html semantic tags, here is a link to understand html semantics ,secondly the main reason why the html semantic tag main is recommended is because it describes the intended usage of the enclosed tags which will form the main content of the page. Lastly all documents are required to have a
h1
tag if headings are being used and it can only go up one-level meaning that if you have ah1
then the next tag in line should be ah2
I hope this helps strengthen the feedback given
Cheers
Marked as helpful2@tesla-ambassadorPosted over 2 years ago@TheCoderGuru Thanks for re-enforcing the feedback πͺ
0@tyihaoPosted over 2 years ago@tesla-ambassador @TheCoderGuru Huge thanks to the both of you for the taking the time to provide the invaluable feedback!
0 - @xsaulPosted over 2 years ago
Hello Tan Yi Hao, you did an amazing job! Just remember that the number of the headings is in order of importance. So in this case instead of <h3> you should use <h1>. Also if you will use only one font write it in the body, like that will be applied on all your site. Congrats for your design!
Marked as helpful1@tyihaoPosted over 2 years ago@xsaul Thank you Saul for the feedback! I will work on it! :-)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord