@romila2003
Posted
Hi Shayne,
Congratulations 🎉 for completing this challenge, the chart component looks great and responsive. There are some issues regarding your HTML, and CSS I want to address:
- The
<br>
tag seems quite unnecessary in your code since theflex
property centers the card already and there is enough gap between the header and the top. - It is best practice to wrap the main content within the
main
tag which would ensure that your content is wrapped within the correct landmarks e.g.<main class="container"></main>
- You should also wrap the header within the
header
tag e.g<header></header>
- Instead of using a
<div>
to get the line under the chart, you can use theborder-top
property on the.chart-footer
instead. - Since you used the
section
tag, you need to a header (any header betweenh2
toh6
).
Overall, great attempt and wish you the best for your future projects 👍.