using html,css(flexbox)

Community feedback

• 

  Shashi Lo•1,345

  @shashiloPosted over 4 years ago

  Hey Esraa. You're getting better at implementing designs, but I do see some areas that you can improve on:

  • The overall container should be max-width: 920px.
  • The method you are using to vertically and horizontally center the project is not ideal. It's not fluid and responsive. I'd remove this and make it margin: auto;. Because you're already using flexbox, add place-items: center;. This will center the elements vertically and horizontally.
  • In the left column, the icon box sizes are inconsistent.
  • Please check the font spacing, white bubble background color, details of the design. There are many little things off about this implementation. Please use PixelPerfect to overlay the design on top of your implementation to view the details I'm talking about.
  • The mobile view is pretty good aside from some padding issues.
  • Look into implementing your CSS mobile first.

  1
• 

  Jen•1,230

  @En-JenPosted over 4 years ago

  Hey there, I'd suggest using flexbox instead of floats to position the smaller elements of the design. For example, you could put the two elements with text "0 GB" and "1000 GB" in a flexbox container and then position them using just justify-content: space-between;. Hope that helps!

  0
• 

  Mohamed Abusrea•160

  @mohamedabusreaPosted over 4 years ago

  Why are you using margin to center the content? try using "align-items" and "justify-content" instead. Also, the design is broken on screens less than 1200px. Try to avoid using fixed values to align items.

  0