_nehal💎• 6,710
@NehalSahu8055
Posted
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
➨ Remove margin-top from .card its not a good way of centering card.
-
To properly center the container.
-
USING FLEXBOX
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
- USING GRID
body{
min-height: 100vh;
display: grid;
place-items: center;
}
➨ Use Semantics for the proper design of your code.
<body>
<header>
<nav>...</nav>
</header>
<main>...</main>
<footer>...</footer>
wrap up `.attribution` inside `footer`
</body>
➨ You can use accessibility features like aria, sr-only, and title which are accessible to screen readers.
I hope you find this helpful.
Happy coding😄
0
