Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Request path contains unescaped characters
Not Found
Not Found
Not Found

Submitted

Using HTML + SCSS

Adam 60

@Vorczu

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, I'm pretty new here, I've done coding before, but never learn the basics. I am open to anyone who can point out my mistakes and point better solution :) I'm unsure to all of my scss, paddings, margins and all. I don't really know when I should use this or that property.

Community feedback

@mustafadede

Posted

Hi Adam! It's me again :D Your button have a border but design not. You should delete your border in your css file like border: 0; Have a good day!

1

Adam 60

@Vorczu

Posted

@mustafadede fixed but i cant generate new view for FEM, thanks for feed :)

0
Yenda 40

@brianayienda

Posted

The layout looks good on large screens but as i tried to minimize it i could notice it remaining static. Perhaps some media queries on the responsiveness would help.

The code is well structured and reusable.

Nice work pal.

1

Adam 60

@Vorczu

Posted

@brianayienda Thanks for feed, I've add 1 step on 625px for 2 views (desc and mobile)

0
Yenda 40

@brianayienda

Posted

@Vorczu great let me check it out

0
Oshu 630

@oshudev

Posted

Hi Adam 👋. You've done well on your first challenge. To have an effective centred flex-box, you should consider having height: 100vh;. In this way, no matter what is the view height, it will constantly position itself in the middle. Also, check the report for other issues as well.

1

Adam 60

@Vorczu

Posted

@eurus1108 thanks for feed, I've already centered this element :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord