Using HTML + SCSS

Community feedback

• 

  Mustafa DEDE•130

  @mustafadedePosted over 2 years ago

  Hi Adam! It's me again :D Your button have a border but design not. You should delete your border in your css file like border: 0; Have a good day!

  1

  ---

  

  Adam•60

  @VorczuPosted over 2 years ago

  @mustafadede fixed but i cant generate new view for FEM, thanks for feed :)

  0
• 

  Yenda•40

  @brianayiendaPosted over 2 years ago

  The layout looks good on large screens but as i tried to minimize it i could notice it remaining static. Perhaps some media queries on the responsiveness would help.

  The code is well structured and reusable.

  Nice work pal.

  1

  ---

  

  Adam•60

  @VorczuPosted over 2 years ago

  @brianayienda Thanks for feed, I've add 1 step on 625px for 2 views (desc and mobile)

  0

  

  Yenda•40

  @brianayiendaPosted over 2 years ago

  @Vorczu great let me check it out

  0
• 

  Oshu•630

  @oshudevPosted over 2 years ago

  Hi Adam 👋. You've done well on your first challenge. To have an effective centred flex-box, you should consider having height: 100vh;. In this way, no matter what is the view height, it will constantly position itself in the middle. Also, check the report for other issues as well.

  1

  ---

  

  Adam•60

  @VorczuPosted over 2 years ago

  @eurus1108 thanks for feed, I've already centered this element :)

  0