using HTML, SASS, JS and BEM.

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted almost 3 years ago

  Hey, really nice work on this one. The desktop layout looks really great, the site is responsive though I don't really know why at 1260px-ish, it goes to mobile state quickly but I didn't saw any @media breakpoint usage on that one. The mobile state looks great as well.

  For some suggestions, here are some:

  • When using img tag, you don't need to add words that relates to "graphic" such as "logo, illustration" and others, since img is already an image so no need to describe it as one. Look at the website's logo as well the hero-section's image.
  • On this one, the hero-section's image doesn't really give any content at all since if you look at it, it is almost blank with no definite content inside it, meaning it is only acting as decoration. Decorative images should be hidden for screen-reader at all times by using alt="" and aria-hidden="true" to the img tag or only aria-hidden="true" if you are using svg instead of img tag.
  • For each of the a tag of the social-media, you could have only used the social-media's name as the value for the aria-label since screen-reader will already announce it as link when traversing a tag so using text that describes that it will redirect user is redundant.

  Aside from those, great job again on this one.

  Marked as helpful

  0