Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Using html and pure css

@Renato-Nakamura


Design comparison


SolutionDesign

Solution retrospective


i'm new and looking for some advice, if you know something i can improve specially in good practices, it would help me a lot!

Community feedback

P
j5 2,290

@jmnyarega

Posted

Hi @Renato-Nakamura

I am so happy for you for getting the challenge done. The hardest part of anything is getting started. congratulations on that.

I have a few notes, especially on the CSS code.

  • Prefer using rem to px, it makes your site more accessible by allowing users to increase or decrease font sizes on their browser settings. em/rem/px.

    • Use custom variables, you've probably heard this acronym DRY(don't repeat yourself) custom variables allow you to create variables that you can re-use throughout your CSS code cusom - variables

    • On the same note of DRY, take advantage of the CSS inheritance, i.e setting text-align: center to an element will apply to all its children. Instead of setting text-align: center on every descendant just set it on the ancestor.

     div // parent div
        - p
        - p
        - div
            - p
    

On the above scenario, setting text-align: center on the parent div will be applied to all elements under it.

Marked as helpful

1

@Renato-Nakamura

Posted

@jmnyarega thanks for this useful notes!! I'll read everything on the links and I will improve for the next challenges!

0
P
j5 2,290

@jmnyarega

Posted

@Renato-Nakamura, glad to hear that.

0
Faris P 2,810

@FarisPalayi

Posted

Yep, there is a lot of text in a small space, and it's hard to read. Give it some space by using paddings or margins🙂

Marked as helpful

1

@Renato-Nakamura

Posted

@FarisPalayi thanks!! I'll be more careful in the future

1
P
j5 2,290

@jmnyarega

Posted

On the design [ just nitpicks] :

  • You can replace the Lorem text with text on the design.
  • You can also, replace EDQ with the logo provided on the images/ folder
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord