Hi @Renato-Nakamura
I am so happy for you for getting the challenge done. The hardest part of anything is getting started. congratulations on that.
I have a few notes, especially on the CSS code.
-
Prefer using rem to px, it makes your site more accessible by allowing users to increase or decrease font sizes on their browser settings. em/rem/px.
-
Use custom variables, you've probably heard this acronym DRY(don't repeat yourself) custom variables allow you to create variables that you can re-use throughout your CSS code cusom - variables
-
On the same note of DRY, take advantage of the CSS inheritance, i.e setting
text-align: center
to an element will apply to all its children. Instead of settingtext-align: center
on every descendant just set it on the ancestor.
div // parent div - p - p - div - p
-
On the above scenario, setting text-align: center
on the parent div will be applied to all elements under it.
Marked as helpful
@Renato-Nakamura
Posted
@jmnyarega thanks for this useful notes!! I'll read everything on the links and I will improve for the next challenges!
@Renato-Nakamura, glad to hear that.