Skip to content
Submitted 7 months ago

Using html and css to complete qr code challenge

ericcheng09•20
@ericcheng09
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

first time combine html with css

What challenges did you encounter, and how did you overcome them?

unfamiliar with css. took time to google css usage.

What specific areas of your project would you like help with?

not sure

Community feedback

  • Grego•1,310
    @Grego14Posted 7 months ago

    Hello! 🎉 congratulations on completing the challenge! 🎉

    There is no need to add margin: 0 auto; to the .container since in the body you only need to add the justify-content: center; property to center the .container.

    The margin: 0 1em in the .card element is unnecessary.

    In the .text element you should use margin: 22px 10px instead of padding: 22px 10px, of course the same thing is achieved but the margin and the padding have different uses.

    Don't skip the headings, you are using a h2 when you should be using a h1.

    I hope this helps! 😁

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord