Using HTML and CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Alex, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • remove all margin, position, left and display properties from .qr-code class
  • bottom and left properties from h6
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px try to use relative units of measurement -> read here

  Overall you did well 😉

  Hope this help and happy coding!

  0
• 

  Taha•310

  @thaykrglPosted over 2 years ago

  Congrats on your effort to solve this design. Here's one tip from my perspective: You can centralize your card with specific width value and margin: auto Achieve this,

  1. You can add a div tag to contain your div tag that has .qr-code class
  2. Add specific width and margin: auto to your div with .qr-code class

  0

  ---

  

  Alex•180

  @alienmarssPosted over 2 years ago

  @thaykrgl thanks for your advice. I will try it

  0