Travolgi πβ’ 31,420
@denielden
Posted
Hi Alex, good job! I took some time to look at your code and have some ideas for improving it:
- add
main
tag and wrap the card for improve the Accessibility - remove all
margin, position, left and display
properties from.qr-code
class bottom and left
properties fromh6
- try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
try to use relative units of measurement -> read here
Overall you did well π
Hope this help and happy coding!
0