@hassanahmadp
Posted
Well done Shafiq!
You have done a great job. Here are a few suggestions for you:
- You should use only those font-weights which are recommended in the
style-guide.md. - For adding a background color you don't need to make a separate div and give it a background-color (correct me if I am wrong).
- Give the body a
height: 100vh;andwidth: 100vw;and there is no need to have a div classedbackgroundand if it is necessary then you can give itheight: 100%;andwidth: 100%;.
Other than that everything is done perfectly... I have also done this project... Here is the link to that have a look and give me suggestions too.
@ShaFreak95
Posted
@hassanahmadp hey Hassan, thank you so much for the tips! I'll make a note of that so I will not do the same mistakes again!
I learned Web Dev from a course in Udemy and the instructor recommends to practise what I've learned (not completing it yet because I want to practise my HTML and CSS) so far here. The suggestions that you wrote here aren't covered by her (yet?) so I appreciate these inputs :D
Thank you once again!
@hassanahmadp
Posted
@ShaFreak95 Hello Shafiq!
The suggestions which I have given you are not taught in any of the courses but you learn them by having bad time experiences when you spend hours and hours to solve a bug and then it comes out to be a stupid mistake 😂. At that time you realize that I am definitely not going to repeat that mistake. And that's how learning happens.
One more thing, Is the Udemy course that you are taking is a sort of Bootcamp? If yes then they are just not going to tell you much. For HTML and CSS only, I found This course the best so far...
Keep Working, Regards.
