Design comparison
Community feedback
- @gopinath-97Posted about 1 month ago
You have made this great and just a slight recommedation, you can use grid or flex to center the items and this would reduce the code instead of using the positioning. Great work and keep on learning.😊🙌
Marked as helpful1 - @Safaa66Posted about 1 month ago
@gopinath-97 Thank you, I will do that in the next challenges 😊
1 - @AdrianoEscarabotePosted about 1 month ago
Hi Safaa Elmhalawy, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:
Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.
<h1>Welcome to QR code component</h1>
The rest is excellent.
I hope you find it useful. 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord