Using Grid to responsive

Community feedback

• 

  Boris•2,850

  @mkborisPosted 4 months ago

  Nice work HMQui, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around card. It's not good practice to wrap every element in div because divs aren't semantic.
  • To improve the semantic meaning of these social media links, you should use the a (anchor) tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content. Also using an unordered list ul to group the social media links is a better approach for both semantics and accessibility.
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Media queries should be defined in rem not px

  Hope this helps

  Marked as helpful

  0

  ---

  

  HMQui•70

  @HMQuiPosted 4 months ago

  Hi Boris, First words, I want to say thank you for feedback to my code.This is one of my first projects and I got so many problems so that I'm appreciated to all your feedback, which help me a lot. I'll review my code and rewrite it.Thank you sir! Have a nice day.

  1

  

  Boris•2,850

  @mkborisPosted 4 months ago

  @HMQui No problem, keep going

  Marked as helpful

  0