using grid to finish this 3-column-card

Community feedback

• 

  Arthur Roberts•410

  @arfarobsPosted over 2 years ago

  下午好呀！看起来很棒。I have a few suggestions for you.

  1. I suggest adding some attributes to the <img> icons. <img src="./images/icon-sedans.svg" alt="" aria-hidden="true"> If an image is decorative, you should add an empty alt attribute. Then, add an aria-hidden="true". This will hide the element from accessibility tools.

  2. I suggest wrapping your content in a <main> element. Landmark elements are important for accessibility.

  3. I noticed that nearly everything is wrapped withing <div>s. It would be better to use some other elements.

     • For headings use: <h1> <h2> <h3> <h4> <h5> <h6> in that order.
     • For paragraphs use: <p>
     • For buttons use: <button>

  I hope this helps. 因为我注意到你来自台湾，所以我觉得你会说中文。下面有两个网站， 第一个是真的很有用，有中文和英文。

  • https://developer.mozilla.org/zh-CN/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-hidden_attribute
  • https://www.w3.org/TR/wai-aria-practices/examples/landmarks/HTML5.html

  Marked as helpful

  0