Using flexboxes, hovers, and cards

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hey Mohit, great job finishing this! Even though it took you a lot of time, I'm sure it feels pretty rewarding to have figured out the problem, and I'm also sure you learned a lot along the way 🙂

  Some feedback I have:

  1. The overlay looks great! Now that you tried positioning it, here's what you can try doing instead: since the overlay goes on top of the image, it makes sense to make the overlay anchored to the image and be positioned in relation to the image. What I would do is, I would move the overlay inside .nftimg and then add position: relative to .nftimg, and then I'd change the CSS as follows:

     .card {
        padding: 1rem;
     }
     .nftimg {
        position: relative;
        cursor: pointer;
     }
     .nftimg img {
       display: block;
       width: 100%;
      // remove height and margin
     }
     .viewoverlay {
       width: 100%;
       height: 100%;
       top: 0;
       border-radius: 10px;
       background-color: hsla(178, 100%, 50%, 0.6);
     }
     .viewoverlay img {
        display: none;
      }
     .viewoverlay:hover img {
        display: block;
      }
     .viewoverlay:hover{
       opacity: 1;
       transition: 500ms;
     }
     // you can remove .view
     

  2. I see that there's a margin: 100px auto being used on .nft-card, which I assume is for centering the component. Instead of using that, you're actually really close to centering it because I see that you got flexbox in the container. All you need to do is, change the margin to 1rem so that there's some space around the component, and then add min-height: 100vh, which should get things looking centered!

  3. Lastly, I'd remove the width and height on .card and give it a responsive max-width: 25em, which should make it be resized even when the browser width is smaller. You may want to change the mobile view as well, such as removing margin:20px auto!

  Marked as helpful

  1

  ---

  

  Mohit Jain•190

  @MOHITBILALAPosted about 2 years ago

  @elaineleung Thank you for the suggestion, I will try this and solve all errors

  1
• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Mohit Jain,

  Congratulation on finishing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  For the same reason, you can use <a> to wrap Equilibrium #3429 and Jules Wyvern.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • Never use <div> and <span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • In this challenge, you may use <h1> for ` Equilibrium #3429``.

  • For middle part of the card class="nftimginfo" , you can use an unordered list <ul>, in each <li> there should be <img> and <p>. That way you can align them centrally.

  • Images must have alt attribute. For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be empty. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <div class="line"></div>, you can use border-top: to the avatar's part.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.

  Clean up the HTML there are some typo : </nft-text>, Also is there <active> tag in HTML ?

  Aside these, great job on this one. Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Mohit Jain•190

  @MOHITBILALAPosted about 2 years ago

  @PhoenixDev22 Thanks a lot, I will improve my code structure next time

  0

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @MOHITBILALA Glad to help. Happy coding!

  0