Using Flexboxes for responsiveness(updated alts and sections)

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Drew Hosick!

  I have some feedback on this solution:

  • For the logo image, you don't need to put the "logo" word for the alternative text. It's already inside the img tag. Just use the company name for the alt value.
  • The download buttons should be a link, since it will download something.
  • For any decorative images, you should leave the alt="" empty and add aria-hidden="true" to make the screen readers ignore those images.
  • About your commit message that says "final changes", I would not recommend to do that, instead you should give your commit message with more meaningful message, like "Fixed typo", " Added x feature", etc.
  • For your class name, I recommend to use dash to separate two words, instead of doing camelCase. It's a common practice to write HTML class.

  <div class="more-details__preview"></div>
  

  • Remove this development code.

  /* ### Primary
  - Strong Cyan: hsl(171, 66%, 44%)
  - Light Blue: hsl(233, 100%, 69%)
  - Dark Grayish Blue: hsl(210, 10%, 33%)
  - Grayish Blue: hsl(201, 11%, 66%) */
  

  That's it! Hopefully this is helpful!

  Marked as helpful

  1