Atif Iqbal• 3,200
@atif-dev
Posted
Hi hanny, congrats🎉 on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
(why main matters? Read here)
- For proper centering the container(whole card) vertically and horizontally you can simply use code as:
body {
min-height: 100vh;
display: grid;
place-content: center;
}
- When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
- Write more in your GitHub project's README file. Like, write about your working flow, findings, new learned things, useful resources, etc.
Hope you will find this Feedback Helpful.
Marked as helpful
0
