using flexbox , js

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hi, esraagamal! 👋

  Nice work on this challenge! I like the animation in your hamburger menu! 🙌

  In addition to emestabillo's feedback on your arrow buttons, I suggest,

  • Making the background of the arrows change to a lighter color (rather than changing their opacity) upon hover so that the content of the page doesn't show through the back of the buttons.
  • Also, there's quite a bit of space between the navigation links in the header of the page. Decreasing that space would bring them closer together and easier to see.

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  esraagamal•600

  @EsraaGamal-22Posted about 4 years ago

  @ApplePieGiraffe thanks alot for your opinion 😄 , can you see my code after the update?

  0

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  @EsraaGamal-22

  I see you've fixed both of those issues. Great work! 👍

  😁

  0
• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 4 years ago

  Hi Esraa, it's me again lol :-) Much improved wow, I can see a lot more control of the design. Just two things here:

  • It looks like you had a bit of a time aligning the arrows as the screen sizes change. One suggestion is nesting the arrows inside slide-pics (so that it becomes their parent), and then using position: relative on this image container. You would still need media queries because the layout is different on desktop, but it probably won't be as many as you have now.

  • The images start to look huge compared to the text between 900px to 1200px

  Hope this helps :-)

  1

  ---

  

  esraagamal•600

  @EsraaGamal-22Posted about 4 years ago

  @emestabillo Hi Em 😄 , can you my code after the update?

  0

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 4 years ago

  @EsraaGamal-22 Looks better Esraa. I think if you set bottom: 0 from the start for the arrows, the styling to larger widths would be easier. Just my opinion :-) But overall looks good!

  0