Design comparison
Solution retrospective
Please, I need feedback.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
POINTING CURSOR βοΈ:
- Looks like the component's
button
element has not a pointer, this property plays a major-role in terms of both UI & UX
- The
cursor: pointer
CSS property is important for button-like elements because it changes the cursor from the default arrow to a pointer when hovering over the element. This provides a visual cue to the user that the element is clickable and encourages interaction.
- In terms of UI/UX, using
cursor: pointer
helps to improve the usability of the interface by making it easier for users to identify interactive elements. It also helps to provide feedback to the user by indicating which elements are clickable and which are not.
- So we want to add this property to the following
add to cart button
element
button { cursor: pointer; }
- Now your component's
button
has got the pointer & you learned about this property as well
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @coffeeslammerPosted over 1 year ago
Here is a couple things Look into <Picture> element and srcset. It will resize your picture for you without css.
<picture class="perfume-images"> <source srcset="./images/image-product-desktop.jpg" media="(min-width: 39.75rem)"> <img src="./images/image-product-mobile.jpg" alt="perfume"> </picture>
The Perfume should be your H1. Think of your H's as a file structure. If they were folders H1 is the root folder and all other H's are sub-folders. Perfume would be the main folder and brands would be stored in that folder (figuratively speaking). The brand here would be a <P>.
Always use CSS to do uppercase. A screen reader may interpret uppercase in html text as being an acronym and may read it as letters rather than words. Use text-transform in CSS.
The prices shouldn't be H's either.
Hope this helps on your learning journey.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord