Using Flexbox

Community feedback

• 

  Kamil•260

  @WuczekPosted over 1 year ago

  Great job!

  Your <main> tag isn't closed with closeup tag </main>

  I don't think you needed to use height property on your image, it should be auto, also I don't think it's a good practice to use unit vw in all of your widths (maybe not particularly in this project), instead of it use something like em,px or % Try to give your main container a certain width and your image just width:100% and it should be working a little bit better

  You can check my how I did that challenge here: My github repo

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • We want to Use min-height: 100vh instead of height.

  ---

  • Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  ---

  • So change, the following style rule

  body {
      height: 100vh;
  }
  

  ---

  • To this,

  ---

  body {
      min-height: 100vh;
  }
  

  I hope you find it helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  Enis67•140

  @Enis67Posted over 1 year ago

  @0xAbdulKhalid

  i dont have body element in my code?

  0