Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Using Flexbox

Enis67 140

@Enis67

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would be very grateful for tips for better coding

Community feedback

Kamil 260

@Wuczek

Posted

Great job!

Your <main> tag isn't closed with closeup tag </main>

I don't think you needed to use height property on your image, it should be auto, also I don't think it's a good practice to use unit vw in all of your widths (maybe not particularly in this project), instead of it use something like em,px or % Try to give your main container a certain width and your image just width:100% and it should be working a little bit better

You can check my how I did that challenge here: My github repo

0

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • We want to Use min-height: 100vh instead of height.
  • Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
  • So change, the following style rule
body {
    height: 100vh;
}
  • To this,
body {
    min-height: 100vh;
}

I hope you find it helpful 😄 Above all, the solution you submitted is great !

Happy coding!

0

Enis67 140

@Enis67

Posted

@0xAbdulKhalid

i dont have body element in my code?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord