using flexbox

Community feedback

• 

  Hatamovich•93

  @HatamovichPosted over 4 years ago

  Hello Esra Gamal 😊 I would recommend you to wrap your content inside a container and center it and also always consider adding cursor: pointer; to you buttons. I also highly recommend you to use meaningful class names. try not to use names like "cont-1, cont-2, cont-1-2 , cont-2-2".

  If you do not know what that container (wrapper) does then I strongly recommend you to go and do some research and learn how to center your content on the page, and learn why and how to use percentage units :)

  http://css-tricks.com is a nice place to learn some cool and useful stuff.

  Sorry for my English if you find it terrible :D I hope my advice will help you to get more comfortable 😊

  1

  ---

  

  esraagamal•600

  @EsraaGamal-22Posted over 4 years ago

  @Hatamovich i'm already using container which contain the main parts of my project then inside it i'm center these main parts.

  0
• 

  Roman Filenko•3,335

  @rfilenkoPosted over 4 years ago

  Hey, optimize it for mobile too, there are some issues with the responsiveness, probably images sizes or flex properties.

  Roman

  0
• 

  Kadu Magalhães•270

  @kdumagalhaesPosted over 4 years ago

  Hey!

  I would add some details like cursor pointer when hovering the buttons and use a (link) instead of p (paragraphs) on footer links and stuff.

  But I think it's really good! Congrats! :)

  0

  ---

  

  esraagamal•600

  @EsraaGamal-22Posted over 4 years ago

  @kdumagalhaes Thanks alot for your review. I'm already edited my code to add these details

  0