Using Flex, Grid, and responsive

Community feedback

• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @AlexDDevv,

  Congrats on completing the challenge

  If you want to position content in the middle of the middle you can replace you rule with the one below.

  header {
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
  }
  

  Also swap out the header tag for a main tag think that would make more semantically sense.

  Hope this is helpful.

  Marked as helpful

  0

  ---

  

  Zoulanders•380

  @AlexDDevvPosted about 2 years ago

  @hyrongennike Hello, thank you for your comment, I take note of your advice !

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Zoulanders, Congratulations on completing this challenge!

  GREAT SOLUTION AND GREAT START!

  Your solution is amazing, you've reached a high level of details and the design is perfect. The only thing missing is the two wave svg as a background. Here's how you can add it:

  To add the two wave svg background images in the (top/bottom),, the best way is by using background-image to manage it since adding them to the body you make sure it will be under everything, to manage different images inside a single css property as background-image you use the comma inside each properties declare the single modification for each wave svg image separated. See the code below to see your solution with those backgrounds applied:

  body {
      background-image: url(./images/bg-pattern-top-desktop.svg), url(./images/bg-pattern-bottom-desktop.svg);
      background-position: left -185px top -236px, right 10px bottom -300px;
      background-repeat: no-repeat;
      background-attachment: fixed;
      background-size: contain, contain;
  }
  

  Improve it using semantics tags to describe what its inside each block of content. You can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

  👾My rating for this solution: ⭐⭐⭐⭐⭐

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Zoulanders•380

  @AlexDDevvPosted about 2 years ago

  @correlucas Hello Lucas, thank you very much for your comment, it's a pleasure to read this ! Indeed, every chall I did, I didn't know how to place the background patern, your advice will be very usefull, thanks again !

  0