using flex

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the element <div class="attribution"> the with semantic element <footer> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  CSS 🎨:

  • let me explain, How you can easily center the component.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  main {
    margin: 5rem 10rem 5rem 10rem;
  }
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  7deniz•70

  @7denizPosted over 1 year ago

  @0xAbdulKhalid thank you so much for your help

  0
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey Deniz,

  I'd suggest not using margin: 5rem 10rem 5rem 10rem; to position the card to the center as it will not work for all sizes, instead try to use something like that:

  body { min-height: 100vh; background-color: hsl(233, 47%, 7%); font-size: 15px; display: flex; justify-content: center; align-items: center; }

  There seems to be few more issues, but shortly:

  • You need to import fonts, u can use google fonts for that, they give you @import css to copy paste at top of your css file.

  For color filter:

  • Just give container of the img a background color like hsl(277, 64%, 61%),
  • Have the image as <img/> inside that container div, instead of as a background-image
  • then apply this css rules to the img: mix-blend-mode: multiply; opacity: .75;

  Hope you find my feedback helpful!

  Marked as helpful

  0

  ---

  

  7deniz•70

  @7denizPosted over 1 year ago

  @visualdenniss thank you so much for your help

  0