using Css-grid and flex-box

Community feedback

• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Congrats on completing the challenge, @saed0920 - it's really on point!

  I saw your code and it's well-written. Just a few suggestions:

  • Put all your @import statements at the very top of your file
  • Place your media queries either at the bottom or in a separate file
  • The usage of grid display is a bit overkill. I assume you wanted to practice display grid and that's perfectly fine, but I'd say that in such cases, it'd be simpler to use flex display where needed.

  Hope my points help. Good job again and looking forward to seeing more of your work!

  Marked as helpful

  1

  ---

  

  Saeed0920•70

  @saeed0920Posted almost 3 years ago

  @Remus432 Hello and thank you very much for your comment. I will definitely follow the points you said in our next works

  0