Using CSS grid

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <article class="cards"> with the main tags to fix the accessibility issue. click here for more on web-accessibility and semantic html

  Wrap the text-content in a div or header tag.

  you forgot to give the body a background-color.

  For a responsive content, give .cards a max-width of 1440px, width of 80% and margin:0 auto or width of 80vw and margin: 0 auto. there is no need to give .card display: flex and its properties.

  in the media query give the header containing the text-content a width of 50% and margin: 0 auto.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of semantic markup, which causes lacking of a landmark for a webpage

  ---

  • So fix it by replacing the <article class="cards"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0