Design comparison
Community feedback
- @Naveen-CBPosted 10 months ago
@mcsimple-net
Hello Vladimir Kvachevski, Let us take your code to another level, by improving sematic HTML.
I have seen there is some unnoticed issue with your HTML but that makes significant impact when scaled in big project:
-
Adding
<main></main>
tag to your html is crucial to improve readability and understandability of your code to both programmers and screen reader and it also plays a major part in SEO so adding main tag is always a best practice . -
Secondly I have seen you used
<ul></ul>
tag in the profile section this makes the screen reader to read this as a list this is indirectly reduce the semantic structure of HTML instead use<div><div>
tag to improve accessibility.
Other than this your code and styling is looking perfect
I hope this might be helpful to you ❤️.
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord