Using CSS

Community feedback

• 

  Muh Suryadi Triputra Rahman•400

  @msuryaditriputraRPosted over 2 years ago

  Hi Suryadi , we have the same name 😅

  First I wanna congrats you for success to finish this challenge 😎🎉 and welcome to the Front-End Mentor community 🔥⚡

  but I have some feedback for your solution ⚒

  • Accessibility Issues

  1. Wrap all of the content with <main> tag, All page content should be contained by landmarks.
  2. If you just have one heading, you have to use h1 for semantic meaning and you can change its style but not the tag. The page should contain a level-one heading.
  3. For the div's attribution, you should wrap it with footer, for better accessibility.

  • Code & Design

  1. You should use CSS for change the background of body. Avoid using bgcolor attribute.
  2. You forget to change the color of the card title, Please check the style guide to see the code hsl colors.
  3. For a style that is close to the origin, you should use box-shadow on the card

  I hope this helps and can improve your code 🙌

  Happy Coding ☕

  Salam dari Makassar 👋😁

  Marked as helpful

  2

  ---

  

  Suryadi Harun•10

  @suryadihrn08Posted over 2 years ago

  @msuryaditriputraR thank you very much mas, i've learn about html about maybe 1 month, but i forget about Main Tag, and semantic tag...

  terima kasih banget udh ngingetin dan yah, aku masih kurang teliti untuk warna cardnya pun aku ga ubah....

  Thanks for feedbacknya

  Salam Dari Bandung

  0

  

  Muh Suryadi Triputra Rahman•400

  @msuryaditriputraRPosted over 2 years ago

  @suryadihrn08 Wah luar biasa, baru sebulan udah bisa segitu... semangat terus belajarnya mas... kalau feedback saya bermanfaat boleh di Mark As Helpful gak mas hehe.. ada di pojok kanan bawah mas..

  Terima Kasih, Happy Coding

  0

  

  Suryadi Harun•10

  @suryadihrn08Posted over 2 years ago

  @msuryaditriputraR oh, oke2 mas.. kurang ngerti soalnya wkkwkw

  0
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Just as a follow up to the previous comment by Muh Suryadi Triputra Rahman, you can read up on semantic tags here

  https://www.w3schools.com/html/html5_semantic_elements.asp

  I hope this helps

  Cheers Happy coding 👍

  Marked as helpful

  1

  ---

  

  Suryadi Harun•10

  @suryadihrn08Posted over 2 years ago

  @TheCoderGuru thanks for the advise :) <3

  0