Using

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Haruto, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • instead of using px try to use relative units of measurement -> read here
  • to make it look as close to the design as possible set width: 100% to img element and add padding: 1rem and text-align: center to .frame class and remove height from it
  • use h1 instead p tag for the title of card
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • remove all margin from .frame class
  • use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  HarutoAmakawa•220

  @HarutoAmakawaPosted over 2 years ago

  @denielden

  Thank you for your advise, this is my first time , so I have a lot of mistake and again thank you so much your advise.

  1