Using basic HTML and CSS properties for this project

Community feedback

• 

  P

  Kent O'Sullivan•1,870

  @12KentosPosted over 2 years ago

  Hey @FlowerWineMonk

  Nice job on completing this challenge! It looks great! I do have a suggestion. I noticed in your css you selected almost all of your elements directly, rather than using a class or an id. Here's an example of what I'm talking about in your code.

  h1{ text-align: center; font-size: 15px; color: darkblue; font-family: 'Franklin Gothic Medium', 'Arial Narrow', Arial, sans-serif; }

  While this is fine for a small project like this, I would highly suggest you start using classes and ids to select your elements with. If you don't this will cause a LOT of headache for you in later/bigger projects.

  If you select an element directly like you did with the h1 element, it not only affects the element in your qr code, but if you had a site with multiple h1 elements in it, ALL of them would be affected by this code. Like I said, not really a big deal in a small project like this, but it's smart to start building good habits from the very beginning.

  Other than that, I think you did a fantastic job! Keep up the coding!

  Marked as helpful

  0