Using basic HTML & CSS

Community feedback

• 

  P

  David Turner•4,150

  @brodiewebdtPosted almost 3 years ago

  The design looks pretty good. the two br tags in the body aren't doing anything and can be removed. Use this code to center the card in the viewport:

  display:grid; place-items:center; min-height: 100vh;

  You want to stay away from floats because they take the content out of the flow of the document and can cause problems later on. Look into using Flexbox instead of floats. Kevin Powell had a video a few days ago on Youtube about Flexbox that might be of help. https://www.youtube.com/watch?v=u044iM9xsWU

  Wrap your container div in a Main tag and it will clear most of the accessibility warnings.

  Download AXE DevTools and you can clear accessibility warnings while you code. https://www.deque.com/axe/devtools/

  Hope this helps.

  Marked as helpful

  0

  ---

  

  Bryan Hutagalung•30

  @nathangalungPosted almost 3 years ago

  @brodiewebdt thank you very muchh bro

  0
• 

  P

  David Turner•4,150

  @brodiewebdtPosted almost 3 years ago

  Your welcome. Glad I could help.

  0
• 

  Zaklina Radivojevic•560

  @zaklinaradivojevicPosted almost 3 years ago

  url:https://nathangalung.github.io/Front-End-Challenge-Newbie/NFT%20Preview%20Card.html

  0