Design comparison
SolutionDesign
Solution retrospective
Hi Everyone, I have completed User Profile Component Challenge. Please have a look and suggest if any improvement need to be done.
Community feedback
- @grace-snowPosted about 4 years ago
A couple of small accessibility pointers:
- leave the alt attribute empty unless the image conveys meaningful information (so empty on things like background images)
- your
stats-num
elements don't really make sense ash3
s. They are part of the line below, reading them together is the only way they make sense, so both should be inside the same html element. You could then wrap each part in aspan
with different classes to control the sizes and make them display block.
Hope that's helpful! 👍
0 - @grace-snowPosted about 4 years ago
Hey, Haven't looked at the code, but thought you'd like to know your solution isn't quite matching the design (viewing on mobile)
- background circles aren't visible
- white border missing from circled image
- divider line is darker than the design
Make a few tweaks and it should be there very soon 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord